Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
branch: jquery_style_c…
Commits on Nov 27, 2010
  1. @neerajdotname
  2. @neerajdotname

    Callback ajax:before is called before any ajax

    neerajdotname authored
    call. jQuery already provides beforeSend callback
    which jquery-ujs uses to provide ajax:beforeSend
    callback.
    
    Anything can be done in ajax:before can also be done
    in ajax:beforeSend callback.
    
    I have been attempting to get the callbacks in
    jquery-ujs close to jQuery and this was the last
    hurdle.
  3. @neerajdotname

    jQuery provides callback named beforeSend.

    neerajdotname authored
    jquery-ujs fires ajax:loading for beforeSend.
    
    A few times I have been confused if loading is
    fired after the request has already been made or
    after.
    
    I guess the best solution is to be as close to
    jQuery as possible. No need to invent new names.
    
    This patch changes callback named ajax:loading to
    ajax:beforeSend.
  4. @neerajdotname

    Since ajax:complete callback is fired when ajax

    neerajdotname authored
    request completes, whether the request ended
    in success or error.
    
    I do not see a need for
    another callback called ajax:after.
  5. @neerajdotname

    bring clarity to ajax:complete callback

    neerajdotname authored
    documentation
  6. @neerajdotname

    Be consistent with the names of callbacks

    neerajdotname authored
    jQuery ajax call has callback named error.
    jquery-ujs has callback ajax:failure.
    Changing that to ajax:error
  7. @neerajdotname
  8. @neerajdotname
  9. @neerajdotname
  10. @neerajdotname
  11. @neerajdotname
  12. @neerajdotname
Commits on Nov 24, 2010
  1. @neerajdotname
  2. @neerajdotname

    If an ajax request is being sent then

    neerajdotname authored
    HTTP_ACCEPT must have text/javascript.
    
    Fixes #52
Commits on Nov 18, 2010
  1. @neerajdotname

    get closer to jQuery. Do not set data-type as

    neerajdotname authored
    'script' arbitrarily.
    
    Possibly might break a few apps. However passing
    data-type is always a good idea. Be in control.
Commits on Nov 15, 2010
  1. @neerajdotname
  2. @JangoSteve @neerajdotname

    Added 'rails' namespace to all live and delegate event bindings.

    JangoSteve authored neerajdotname committed
    Signed-off-by: Neeraj Singh <neerajdotname@gmail.com>
Commits on Nov 14, 2010
  1. @neerajdotname

    fix indentation

    neerajdotname authored
  2. @neerajdotname
  3. @neerajdotname
Commits on Nov 13, 2010
  1. @neerajdotname
Commits on Nov 12, 2010
  1. @neerajdotname

    fix readme link

    neerajdotname authored
  2. @neerajdotname
  3. @neerajdotname

    * master branch is dropping the support for jquery 1.4, 1.4.1 and 1.4…

    neerajdotname authored
    ….2 .
    
    * If you are using one of those versions then use branch v1.4 .
    * All test files have been updated to reflect the same .
  4. @neerajdotname
Commits on Nov 2, 2010
  1. @neerajdotname
Commits on Nov 1, 2010
  1. @neerajdotname

    Revert "Added jquery event binding namespace 'rails' for easy unbindi…

    neerajdotname authored
    …ng of all rails jquery magic."
    
    This reverts commit a9a7b20.
  2. @neerajdotname
  3. @neerajdotname
  4. @neerajdotname

    tidying up words

    neerajdotname authored
  5. @neerajdotname
  6. @neerajdotname
  7. @JangoSteve @josevalim

    Added jquery event binding namespace 'rails' for easy unbinding of al…

    JangoSteve authored josevalim committed
    …l rails jquery magic.
  8. @jherdman @josevalim

    Clean up var declarations

    jherdman authored josevalim committed
  9. @alexcrichton @josevalim

    Allow the two iframe tests to also have a variable jquery version.

    alexcrichton authored josevalim committed
    This also fixes the two tests because since 'vendor/jquery-1.4.2.js' was removed, neither test would pass because jQuery wasn't actually present for the tests sadly.
    
    Now, the index page embeds the jquery version into the request URL, so the two iframes load the same version as the one currently being tested
Something went wrong with that request. Please try again.