Up-to-date async-confirm patches #283

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@jpzwarte

I've redone the async-confirm branch changes on top of master. In the last 4 projects we've done, we've used a non-native confirm dialog every single time. Any change on whether or not to merge this with master? Tests still all pass.

Here's an example using async confirm: https://gist.github.com/3878172

@jpzwarte

I've now run into the situation where event.preventDefault() on a form fails to work. Took me a while to figure out this code was responsible. So i've changed my mind that this is a good idea.

@jpzwarte jpzwarte closed this Dec 22, 2012
@seanlinsley seanlinsley referenced this pull request in activeadmin/activeadmin Jan 8, 2013
Merged

Batch Action forms #1815

@seanlinsley

@jpzwarte, could you go into greater detail over why preventDefault wasn't working? Could you not use stopPropagation instead?

I'd love to have this functionality. For now I'm disabling UJS for a specific subset of links and providing my own handler: https://gist.github.com/4485846

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment