Avoid setting withCredentials to null. Fixes #295. Fixes #279. #300

Merged
merged 1 commit into from Jan 24, 2013

Conversation

Projects
None yet
6 participants
Contributor

ebeigarts commented Jan 3, 2013

This should fix problems with IE6-8 when "Enable native XMLHTTP support" is disabled. For more details see jquery/jquery#751 (comment)

This will fix rails_ujs compatibility with existing jQuery versions so that we don't have to wait while it is fixed in jQuery side and avoid IE headaches for rails_ujs users.

Contributor

ebeigarts commented Jan 9, 2013

This also fixes #277 and is similiar to #281 PR

holli commented Jan 11, 2013

+1 . It's been on production for few days and is working nicely. Thanks. I was wondering where did the bug originally came from.

jarodtaylor referenced this pull request in rails/jquery-rails Jan 14, 2013

Closed

UJS Update ETA? #93

Member

JangoSteve commented Jan 14, 2013

Thanks for the pull request. I'll take a look at this shortly.

rbeene commented Jan 21, 2013

Any word on this PR @JangoSteve ? I'm leveraging the fork for now but would like to get back on the original. Thanks!

germs12 commented Jan 21, 2013

👍

@neerajdotname neerajdotname pushed a commit that referenced this pull request Jan 24, 2013

Neeraj Singh Merge pull request #300 from ebeigarts/fix-xhr-fields-on-ie
Avoid setting withCredentials to null. Fixes #295. Fixes #279.
7858107

@neerajdotname neerajdotname merged commit 7858107 into rails:master Jan 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment