Permalink
Commits on Jun 14, 2017
  1. Merge pull request #92 from amatsuda/active_record_40

    Don't pollute toplevel with active_record_40? method
    rafaelfranca committed on GitHub Jun 14, 2017
Commits on May 4, 2017
  1. Bump version to 1.1.4

    rafaelfranca committed May 4, 2017
  2. Also fix for 4.2-stable

    rafaelfranca committed May 4, 2017
  3. Upgrade copyright year

    rafaelfranca committed May 4, 2017
Commits on Aug 29, 2016
  1. Merge pull request #89 from terceiro/avoid-random-failures

    attribute_sanitization_test: avoid random failures
    rafaelfranca committed on GitHub Aug 29, 2016
  2. attribute_sanitization_test: avoid random failures

    Because test/test_helper.rb sets the tests to run on random order, that
    missing call to `super` will cause tests to crash with the following
    exception, depending on which order the test classes get loaded.
    
    ```
    ActiveRecord::RecordNotUnique: SQLite3::ConstraintException: UNIQUE
    constraint failed: people.id: INSERT INTO "people" ("id", "first_name", "gender", "comments", "best_friend_id", "created_at", "updated_at") VALUES (?, ?, ?, ?, ?, ?, ?)
    ```
    
    On my tests, this seems to happen more or less 6% of the time (i.e. 3
    out of 50 runs). With this change, I was able to make 50 runs without a
    single failure.
    terceiro committed Aug 29, 2016
Commits on Jul 5, 2016
Commits on May 31, 2016
  1. Merge pull request #85 from Edouard-chin/activerecord-exception-names…

    …pace
    
    Fixes the Activerecord::TooManyRecords namespace:
    rafaelfranca committed May 31, 2016
  2. Fixes the Activerecord::TooManyRecords namespace:

    - Class `TooManyRecords` was in the `ActiveRecord::MassAssignmentSecurity::NestedAttributes` namespace, resulting in a `UnitializedConstant` exception
    Edouard-chin committed May 31, 2016
Commits on May 9, 2016
  1. Merge pull request #81 from pacoguzman/avoid-double-callbacks

    Avoid double callbacks in Rails >= 4.1
    arthurnn committed May 9, 2016
Commits on Apr 30, 2016
  1. Merge pull request #83 from kmagai/patch-1

    possible typo in README
    kaspth committed Apr 30, 2016
  2. possible typo in README

    I found it's a possible typo.
    English is not my first language, so I am sorry if it's fine usage 🙇
    kmagai committed Apr 30, 2016
Commits on Jan 8, 2016
  1. Avoid double callbacks

    pacoguzman committed Jan 8, 2016
Commits on Jan 1, 2016
  1. Merge pull request #80 from jeroenvisser101/patch-1

    Update copyright year [ci-skip]
    guilleiguaran committed Jan 1, 2016
  2. Update copyright year

    Happy new year!
    jeroenvisser101 committed Jan 1, 2016
Commits on Jul 14, 2015
  1. Release 1.1.3

    rafaelfranca committed Jul 14, 2015
  2. Merge pull request #76 from Arie/master

    Fix Deprection typo
    rafaelfranca committed Jul 14, 2015
  3. Fix Deprection typo

    Arie committed Jul 14, 2015
  4. Change README to reflect new behavior

    Models without calls to `attr_accessible` or `attr_protected` will use
    strong parameters
    rafaelfranca committed Jul 14, 2015
  5. Release 1.1.2

    rafaelfranca committed Jul 14, 2015
  6. Only remove the method if it is defined

    Closes #75
    rafaelfranca committed Jul 14, 2015
Commits on Jul 13, 2015
  1. Release 1.1.1

    rafaelfranca committed Jul 13, 2015
  2. Merge pull request #73 from rails/better-strong-parameters-integration

    Better strong parameters integration
    rafaelfranca committed Jul 13, 2015
  3. Change default behavior when including the gem

    Before we were permitting all the parameters and forcing to whitelist all
    the attributes. This make harder to upgrade to strong parameters because
    you can't slowly change the models to not use the attribute macros.
    
    Since now we are fallbacking to strong parameters if the macro is not
    defined on the model we should not permit all the parameters neither
    call the macro on ActiveRecord::Base.
    
    Models with macros will use the mass assignment sanitization and models
    without the macros will raise if parameters are not permitted.
    rafaelfranca committed Jun 30, 2015
Commits on Jun 30, 2015
  1. Only fallback to strong parameters if macros are not called

    Before we were fallbacking to mass assignment sanitization even if
    macros were not being called. Now we only check the strong parameter
    protection.
    
    This will make easier to slowly upgrade to use only strong parameters.
    rafaelfranca committed Jun 30, 2015
  2. Only remove the method if it exists

    Fix build for Rails 4.0
    rafaelfranca committed Jun 30, 2015
  3. Remove all method before overriding

    This will avoid warnings
    rafaelfranca committed Jun 30, 2015
  4. Merge pull request #72 from rails/fix-find_by-finders

    Make sure find_or_* and first_or_* methods are overridden
    rafaelfranca committed Jun 30, 2015
  5. Make sure find_by_* helper works with protected_attributes

    When doing the search we should not check for strong parameters if the
    model includes the protection macros.
    rafaelfranca committed Jun 29, 2015
Commits on Jun 28, 2015
  1. README.md copy editing

    fxn committed Jun 28, 2015