Attempt at fixing #8 add all_blank proc #11

Merged
merged 1 commit into from Jun 29, 2013

3 participants

@asanghi

Adding REJECT_ALL_BLANK_PROC proc

Using :reject_if in code to ensure that it doesnt blow up.

Just a bit lost on a proper failing test @pixeltrix (issue #8)

@pixeltrix
Ruby on Rails member

@asanghi since we're overwriting a lot of the nested attribute methods we need tests that exercise a lot of the same things as the tests in the main AR tests - look at the nested attributes test to get an idea of what's needed. Hopefully it's just a copy and paste job!

@pixeltrix
Ruby on Rails member

@asanghi we only need to test the functionality related to the methods we're overriding - config, assignment and destruction.

@rafaelfranca rafaelfranca merged commit bf5a422 into rails:master Jun 29, 2013

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment