Ignore ./rails #3

Merged
merged 1 commit into from Aug 17, 2012

Conversation

Projects
None yet
2 participants
@simonjefford
Contributor

simonjefford commented Aug 17, 2012

This allows users to have a clone in their rails-dev-box checkout that will automatically appear in their /vagrant folder. That way they can edit files "locally" and test the changes on the vagrant box.

Ignore ./rails
This allows users to have a clone in their rails-dev-box checkout that
will automatically appear in their /vagrant folder.
@fxn

This comment has been minimized.

Show comment Hide comment
@fxn

fxn Aug 17, 2012

Owner

This PR comes in the right time. I am pondering changing the "What's next section" to suggest cloning the fork in the home of the box as you do, since git and SSH keys and preferred editor are all set in the host normally. Is it working well for you?

Nevertheless, what is the point of ignoring the "rails" directory? People are not going yo modify the virtual machine itself right?

Owner

fxn commented Aug 17, 2012

This PR comes in the right time. I am pondering changing the "What's next section" to suggest cloning the fork in the home of the box as you do, since git and SSH keys and preferred editor are all set in the host normally. Is it working well for you?

Nevertheless, what is the point of ignoring the "rails" directory? People are not going yo modify the virtual machine itself right?

@simonjefford

This comment has been minimized.

Show comment Hide comment
@simonjefford

simonjefford Aug 17, 2012

Contributor

I guess it's just an OCD thing, my command prompt no longer shows a dirty working folder if "rails" is ignored :-) Also, slightly more seriously, I guess if you are going to contribute a change to rails-dev-box itself this would prevent accidentally adding rails as a submodule.

Agree it's probably of marginal benefit though...

(Either way, adding something to the README to suggest doing this is probably a good idea)

Contributor

simonjefford commented Aug 17, 2012

I guess it's just an OCD thing, my command prompt no longer shows a dirty working folder if "rails" is ignored :-) Also, slightly more seriously, I guess if you are going to contribute a change to rails-dev-box itself this would prevent accidentally adding rails as a submodule.

Agree it's probably of marginal benefit though...

(Either way, adding something to the README to suggest doing this is probably a good idea)

@fxn

This comment has been minimized.

Show comment Hide comment
@fxn

fxn Aug 17, 2012

Owner

On a second thought, that may helpful to me myself also to check how editing from /vagrant works... in then. Thanks!

Owner

fxn commented Aug 17, 2012

On a second thought, that may helpful to me myself also to check how editing from /vagrant works... in then. Thanks!

fxn added a commit that referenced this pull request Aug 17, 2012

@fxn fxn merged commit fab86b3 into rails:master Aug 17, 2012

yahonda referenced this pull request in yahonda/rails-dev-box Jul 10, 2013

Merge pull request #3 from teaforthecat/patch-1
Require "configure xe" in service.

jaw6 referenced this pull request in jaw6/railsmn-dev-box Jul 17, 2013

jaw6 referenced this pull request in jaw6/railsmn-dev-box Jul 17, 2013

Merge pull request #8 from railsmn#3
issue #3. move from 1.9.3 to 2.0.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment