Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license filename in gemspec #47

merged 1 commit into from Jan 26, 2016


None yet
3 participants
Copy link

commented Jan 26, 2016

License filename changed, but not in gemspec.
Which results to not including the license file to gem.

Correct license filename
License filename changed, but not in gemspec.
Which results to not including the file to gem.

This comment has been minimized.

Copy link

commented Jan 26, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rafaelfranca added a commit that referenced this pull request Jan 26, 2016

Merge pull request #47 from pvalena/patch-1
Fix license filename in gemspec

@rafaelfranca rafaelfranca merged commit 6025b50 into rails:master Jan 26, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.