Permalink
2 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Let Hash#slice return a Hash
In order to keep this method compatible with the Ruby 2.5 version of Hash#slice. This bahavior is actually slightly incompatibile with previous versions of Active Support but it might not cause a real problem, since HWIA, the biggest use case of Hash subclassing here, already overrides `slice` to return another HWIA.
- Loading branch information
Showing
with
5 additions
and 1 deletion.
This comment has been minimized.
I think we also need to change i18n because it does not return an instance of
Hash
. See https://travis-ci.org/svenfuchs/i18n/jobs/293285567, that now is failing because of this commit. Mind to open a PR?This comment has been minimized.
@rafaelfranca Ah, thank you for letting me know this! Yes, I'll work on this soon!