Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

prevent mass assignment of polymorphic type when using `build`

Closes #8265
  • Loading branch information...
commit 053bfa2304517fd2eb4e8e7dcb4eb9897f121271 1 parent 293c121
@senny senny authored
View
5 activerecord/CHANGELOG.md
@@ -1,5 +1,10 @@
## Rails 4.0.0 (unreleased) ##
+* Prevent mass assignment to the type column of polymorphic associations when using `build`
+ Fix #8265
+
+ *Yves Senn*
+
* Fix postgresql adapter to handle BC timestamps correctly
HistoryEvent.create!(:name => "something", :occured_at => Date.new(0) - 5.years)
View
3  activerecord/lib/active_record/associations/association.rb
@@ -232,7 +232,8 @@ def stale_state
def build_record(attributes)
reflection.build_association(attributes) do |record|
- attributes = create_scope.except(*(record.changed - [reflection.foreign_key]))
+ skip_assign = [reflection.foreign_key, reflection.type].compact
+ attributes = create_scope.except(*(record.changed - skip_assign))
record.assign_attributes(attributes)
end
end
View
8 activerecord/test/cases/associations/has_many_associations_test.rb
@@ -1579,6 +1579,14 @@ def test_abstract_class_with_polymorphic_has_many
assert_equal [tagging], post.taggings
end
+ def test_build_with_polymotphic_has_many_does_not_allow_to_override_type_and_id
+ welcome = posts(:welcome)
+ tagging = welcome.taggings.build(:taggable_id => 99, :taggable_type => 'ShouldNotChange')
+
+ assert_equal welcome.id, tagging.taggable_id
+ assert_equal 'Post', tagging.taggable_type
+ end
+
def test_dont_call_save_callbacks_twice_on_has_many
firm = companies(:first_firm)
contract = firm.contracts.create!
Please sign in to comment.
Something went wrong with that request. Please try again.