Permalink
Browse files

Make execute, change_column and remove_columns methods actually irrev…

…ersible

[#8267]
  • Loading branch information...
1 parent e43e8e2 commit 06c7ba881d008be82d62656f297d6a3c09a889c5 @marcandre marcandre committed Dec 19, 2012
@@ -73,7 +73,8 @@ def respond_to?(*args) # :nodoc:
[:create_table, :create_join_table, :rename_table, :add_column, :remove_column,
:rename_index, :rename_column, :add_index, :remove_index, :add_timestamps, :remove_timestamps,
:change_column, :change_column_default, :add_reference, :remove_reference, :transaction,
- :drop_join_table, :drop_table, :remove_columns, :remove_index,
+ :drop_join_table, :drop_table, :remove_index,
+ :change_column, :execute, :remove_columns, # irreversible methods need to be here too
].each do |method|
class_eval <<-EOV, __FILE__, __LINE__ + 1
def #{method}(*args, &block) # def create_table(*args, &block)
@@ -34,12 +34,18 @@ def test_unknown_commands_delegate
assert_equal 'bar', recorder.foo
end
- def test_unknown_commands_raise_exception_if_they_cannot_delegate
+ def test_inverse_of_raise_exception_on_unknown_commands
assert_raises(ActiveRecord::IrreversibleMigration) do
@recorder.inverse_of :execute, ['some sql']
end
end
+ def test_irreversible_commands_raise_exception
+ assert_raises(ActiveRecord::IrreversibleMigration) do
+ @recorder.revert{ @recorder.execute 'some sql' }
+ end
+ end
+
def test_record
@recorder.record :create_table, [:system_settings]
assert_equal 1, @recorder.commands.length

0 comments on commit 06c7ba8

Please sign in to comment.