Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Clean up dependent option validation.
We don't need the complexity of to_sentence, and it shouldn't be a bang method.
- Loading branch information
1 parent
5ad7998
commit 08fb3c8
Showing
4 changed files
with
7 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08fb3c8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kinda agree with
to_sentence
, and the bang thing was added following other similar check methods in Active Record (such asRelation#check_validity!
. Anyway, I see this was further refactored later, thanks.