Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Merge pull request #14727 from robin850/patch-17

Add a changelog entry for #14546 [ci skip]
  • Loading branch information...
commit 090db0ff7d2611846aef0b38f741dda6204849ce 2 parents 47d9321 + 5d5becc
@senny senny authored
Showing with 14 additions and 0 deletions.
  1. +14 −0 activerecord/CHANGELOG.md
View
14 activerecord/CHANGELOG.md
@@ -1,3 +1,17 @@
+* Calling `delete_all` on an unloaded `CollectionProxy` no longer
+ generates a SQL statement containing each id of the collection:
+
+ Before:
+
+ DELETE FROM `model` WHERE `model`.`parent_id` = 1
+ AND `model`.`id` IN (1, 2, 3...)
+
+ After:
+
+ DELETE FROM `model` WHERE `model`.`parent_id` = 1
+
+ *Eileen M. Uchitelle*, *Aaron Patterson*
+
* Fixed error for aggregate methods (`empty?`, `any?`, `count`) with `select`
which created invalid SQL.
Please sign in to comment.
Something went wrong with that request. Please try again.