Permalink
Browse files

We dont actually use the ultra short-hand, so no need to complicate t…

…hings with it
  • Loading branch information...
dhh committed May 24, 2017
1 parent e0318bf commit 0b8441bd415c444b8d4afbfc93af79ec7677aa2c
Showing with 1 addition and 1 deletion.
  1. +1 −1 railties/lib/rails/generators/rails/app/templates/Gemfile
@@ -1,5 +1,5 @@
source 'https://rubygems.org'
git_source(:github) { |repo| "https://github.com/#{repo.include?("/") ? repo : "#{repo}/#{repo}"}.git" }
git_source(:github) { |repo| "https://github.com/#{repo}.git" }
<% gemfile_entries.each do |gem| -%>
<% if gem.comment -%>

5 comments on commit 0b8441b

@kaspth

This comment has been minimized.

Show comment
Hide comment
@kaspth

kaspth May 25, 2017

Member

We don't use it when the app is generated, but users might.

Member

kaspth replied May 25, 2017

We don't use it when the app is generated, but users might.

@dhh

This comment has been minimized.

Show comment
Hide comment
@dhh

dhh May 25, 2017

Member
Member

dhh replied May 25, 2017

@kaspth

This comment has been minimized.

Show comment
Hide comment
@kaspth

kaspth May 25, 2017

Member

No, but for the repos that do, and for the users that try to use the short form, we'd make their bundling less secure — and this code was added for security after all.

Member

kaspth replied May 25, 2017

No, but for the repos that do, and for the users that try to use the short form, we'd make their bundling less secure — and this code was added for security after all.

@dhh

This comment has been minimized.

Show comment
Hide comment
@dhh

dhh May 25, 2017

Member
Member

dhh replied May 25, 2017

@kaspth

This comment has been minimized.

Show comment
Hide comment
@kaspth

kaspth May 25, 2017

Member

👍

Member

kaspth replied May 25, 2017

👍

Please sign in to comment.