Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fix broken ActionController#action_missing

A recent change introduced the assumption that all controller actions
are known beforehand, which is not true when using action_missing.
  • Loading branch information...
commit 0dfa6cb97c77775164f8009d6be82e697bd25add 1 parent 66ac0c5
@gufo gufo authored
View
5 actionpack/CHANGELOG.md
@@ -1,5 +1,10 @@
## Rails 4.0.0 (unreleased) ##
+* Fixed ActionController#action_missing not being called.
+ Fixes GH#9799.
+
+ *Janko Luin*
+
* Ensure that digest authentication responds with a 401 status when a basic
header is received.
View
2  actionpack/lib/action_controller/metal/hide_actions.rb
@@ -27,7 +27,7 @@ def hide_action(*args)
end
def visible_action?(action_name)
- action_methods.include?(action_name)
+ not hidden_actions.include?(action_name)
end
# Overrides AbstractController::Base#action_methods to remove any methods
View
12 actionpack/test/controller/base_test.rb
@@ -68,6 +68,12 @@ class RecordIdentifierWithoutDeprecationController < ActionController::Base
include ActionView::RecordIdentifier
end
+class ActionMissingController < ActionController::Base
+ def action_missing(action)
+ render :text => "Response for #{action}"
+ end
+end
+
class ControllerClassTests < ActiveSupport::TestCase
def test_controller_path
@@ -186,6 +192,12 @@ def test_get_on_hidden_should_fail
assert_raise(AbstractController::ActionNotFound) { get :hidden_action }
assert_raise(AbstractController::ActionNotFound) { get :another_hidden_action }
end
+
+ def test_action_missing_should_work
+ use_controller ActionMissingController
+ get :arbitrary_action
+ assert_equal "Response for arbitrary_action", @response.body
+ end
end
class UrlOptionsTest < ActionController::TestCase
Please sign in to comment.
Something went wrong with that request. Please try again.