Permalink
Browse files

Remove deprecated `ActiveRecord::Base.disable_implicit_join_references=`

  • Loading branch information...
rafaelfranca committed Jan 4, 2015
1 parent efdc20f commit 0fbd1fc888ffb8cbe1191193bf86933110693dfc
Showing with 4 additions and 13 deletions.
  1. +4 −0 activerecord/CHANGELOG.md
  2. +0 −7 activerecord/lib/active_record/core.rb
  3. +0 −6 activerecord/test/cases/relations_test.rb
@@ -1,3 +1,7 @@
+* Remove deprecated `ActiveRecord::Base.disable_implicit_join_references=`.
+
+ *Rafael Mendonça França*
+
* Remove deprecated access to connection specification using a string acessor.
Now all strings will be handled as a URL.
@@ -87,13 +87,6 @@ def self.configurations
mattr_accessor :maintain_test_schema, instance_accessor: false
- def self.disable_implicit_join_references=(value)
- ActiveSupport::Deprecation.warn(<<-MSG.squish)
- Implicit join references were removed with Rails 4.1.
- Make sure to remove this configuration because it does nothing.
- MSG
- end
-
class_attribute :default_connection_handler, instance_writer: false
class_attribute :find_by_statement_cache
@@ -1382,12 +1382,6 @@ def test_primary_key
assert_equal "id", Post.all.primary_key
end
- def test_disable_implicit_join_references_is_deprecated
- assert_deprecated do
- ActiveRecord::Base.disable_implicit_join_references = true
- end
- end
-
def test_ordering_with_extra_spaces
assert_equal authors(:david), Author.order('id DESC , name DESC').last
end

0 comments on commit 0fbd1fc

Please sign in to comment.