Skip to content

Commit 0fbd1fc

Browse files
committed
Remove deprecated ActiveRecord::Base.disable_implicit_join_references=
1 parent efdc20f commit 0fbd1fc

File tree

3 files changed

+4
-13
lines changed

3 files changed

+4
-13
lines changed

activerecord/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
* Remove deprecated `ActiveRecord::Base.disable_implicit_join_references=`.
2+
3+
*Rafael Mendonça França*
4+
15
* Remove deprecated access to connection specification using a string acessor.
26

37
Now all strings will be handled as a URL.

activerecord/lib/active_record/core.rb

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -87,13 +87,6 @@ def self.configurations
8787

8888
mattr_accessor :maintain_test_schema, instance_accessor: false
8989

90-
def self.disable_implicit_join_references=(value)
91-
ActiveSupport::Deprecation.warn(<<-MSG.squish)
92-
Implicit join references were removed with Rails 4.1.
93-
Make sure to remove this configuration because it does nothing.
94-
MSG
95-
end
96-
9790
class_attribute :default_connection_handler, instance_writer: false
9891
class_attribute :find_by_statement_cache
9992

activerecord/test/cases/relations_test.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1382,12 +1382,6 @@ def test_primary_key
13821382
assert_equal "id", Post.all.primary_key
13831383
end
13841384

1385-
def test_disable_implicit_join_references_is_deprecated
1386-
assert_deprecated do
1387-
ActiveRecord::Base.disable_implicit_join_references = true
1388-
end
1389-
end
1390-
13911385
def test_ordering_with_extra_spaces
13921386
assert_equal authors(:david), Author.order('id DESC , name DESC').last
13931387
end

0 commit comments

Comments
 (0)