Permalink
Browse files

Merge pull request #12842 from kuldeepaggarwal/array_split

Speed up Array#split when block is passed
  • Loading branch information...
2 parents d17e79b + 4aadd16 commit 15ef6bed18ce144d7fa0670b22d80aeeb4237bd8 @guilleiguaran guilleiguaran committed Nov 11, 2013
Showing with 3 additions and 3 deletions.
  1. +3 −3 activesupport/lib/active_support/core_ext/array/grouping.rb
@@ -83,10 +83,10 @@ def in_groups(number, fill_with = nil)
#
# [1, 2, 3, 4, 5].split(3) # => [[1, 2], [4, 5]]
# (1..10).to_a.split { |i| i % 3 == 0 } # => [[1, 2], [4, 5], [7, 8], [10]]
- def split(value = nil, &block)
- if block
+ def split(value = nil)
+ if block_given?
inject([[]]) do |results, element|
- if block.call(element)
+ if yield(element)
results << []
else
results.last << element

0 comments on commit 15ef6be

Please sign in to comment.