Permalink
Browse files

Merge pull request #13235 from strzalek/variants-inline

Inline syntax for variants
  • Loading branch information...
2 parents cad9eb1 + 2647d2f commit 186161148a189839a1e0924043f068a8d155ce69 @dhh dhh committed Dec 8, 2013
@@ -215,7 +215,7 @@ def respond_to(*mimes, &block)
raise ArgumentError, "respond_to takes either types or a block, never both" if mimes.any? && block_given?
if collector = retrieve_collector_from_mimes(mimes, &block)
- response = collector.response(request.variant)
+ response = collector.response
response ? response.call : render({})
end
end
@@ -357,7 +357,7 @@ def respond_with(*resources, &block)
if collector = retrieve_collector_from_mimes(&block)
options = resources.size == 1 ? {} : resources.extract_options!
options = options.clone
- options[:default_response] = collector.response(request.variant)
+ options[:default_response] = collector.response
(options.delete(:responder) || self.class.responder).call(self, resources, options)
end
end
@@ -390,7 +390,7 @@ def collect_mimes_from_class_level #:nodoc:
# is available.
def retrieve_collector_from_mimes(mimes=nil, &block) #:nodoc:
mimes ||= collect_mimes_from_class_level
- collector = Collector.new(mimes)
+ collector = Collector.new(mimes, request.variant)
block.call(collector) if block_given?
format = collector.negotiate_format(request)
@@ -428,9 +428,11 @@ class Collector
include AbstractController::Collector
attr_accessor :format
- def initialize(mimes)
+ def initialize(mimes, variant = nil)
@responses = {}
- mimes.each { |mime| send(mime) }
+ @variant = variant
+
+ mimes.each { |mime| @responses["Mime::#{mime.upcase}".constantize] = nil }
end
def any(*args, &block)
@@ -444,15 +446,19 @@ def any(*args, &block)
def custom(mime_type, &block)
mime_type = Mime::Type.lookup(mime_type.to_s) unless mime_type.is_a?(Mime::Type)
- @responses[mime_type] ||= block
+ @responses[mime_type] ||= if block_given?
+ block
+ else
+ VariantFilter.new(@variant)
+ end
end
- def response(variant)
+ def response
response = @responses.fetch(format, @responses[Mime::ALL])
- if response.nil? || response.arity == 0
+ if response.is_a?(VariantFilter) || response.nil? || response.arity == 0
response
else
- lambda { response.call VariantFilter.new(variant) }
+ lambda { response.call VariantFilter.new(@variant) }
end
end
@@ -175,6 +175,12 @@ def variant_plus_none_for_format
end
end
+ def variant_inline_syntax
+ respond_to do |format|
+ format.html.phone { render text: "phone" }
+ end
+ end
+
protected
def set_layout
case action_name
@@ -554,10 +560,16 @@ def test_multiple_variants_for_format
assert_equal "tablet", @response.body
end
-
def test_no_variant_in_variant_setup
get :variant_plus_none_for_format
assert_equal "text/html", @response.content_type
assert_equal "none", @response.body
end
+
+ def test_variant_inline_syntax
+ @request.variant = :phone
+ get :variant_inline_syntax
+ assert_equal "text/html", @response.content_type
+ assert_equal "phone", @response.body
+ end
end

0 comments on commit 1861611

Please sign in to comment.