Browse files

Use `:rubygems` shortcut as standard Gemfile's `source` instead of ex…

…plicit URL.

Theoretically this would future-proof Gemfiles against possible (albeit unlikely) change in the rubygems URL.
  • Loading branch information...
1 parent 522c0fd commit 1873adf6e4863b65830473ce213768a02bea5fe7 @rossmeissl rossmeissl committed Jan 26, 2012
Showing with 1 addition and 1 deletion.
  1. +1 −1 railties/lib/rails/generators/rails/app/templates/Gemfile
2 railties/lib/rails/generators/rails/app/templates/Gemfile
@@ -1,4 +1,4 @@
-source ''
+source :rubygems
<%= rails_gemfile_entry -%>

5 comments on commit 1873adf

Ruby on Rails member

This obfuscates the URL and doesn't actually future proof the bundle.

If anything, it'd be really confusing if the symbol started pointing to some other URL.

/cc @guilleiguaran

Ruby on Rails member

@jeremy not sure about what to do in this case, revert to or change to

cc @tenderlove

Ruby on Rails member

That's a convenient alias that is meant to be used I guess :), I bet many people use it and should not be a problem in the future because of that. I personally prefer the alias, though if you guys feel strong about configuring a URL please go ahead.

Ruby on Rails member

Given the ssl problems people have been reporting, I actually do feel pretty strongly about using the url. Without the url showing the protocol, I think people have even less of a chance to debug issues.

@guilleiguaran We should revert to https.


Sorry for the hassle folks!

Please sign in to comment.