Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added back ActionController::Base.allow_concurrency flag and moved lo…
…ck down to controller processing.
- Loading branch information
Showing
3 changed files
with
23 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19db0b7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the whole Rails framework now actually thread-safe so that we can have a multithreaded Rails app with
ActionController::Base.allow_concurrency = ActiveRecord::Base.allow_concurrency = true
?19db0b7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Routes are (as of a5db148), so I moved the lock down. ActiveRecord connection pool is not committed yet, so no.
19db0b7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AR still needs to merge the connection pool work from nick sieger, and of course we need to test the hell out of it.
You’re almost guaranteed to get better per-meg-of-memory performance with passenger and ruby-enterprise-edition than with a threaded mongrel or whatever. However it should help out the jruby guys.
19db0b7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josh & NZKoz
OK. I didn’t know about Nick Sieger’s connection_pool branch. Thanks!