Permalink
Browse files

Merge pull request #10190 from senny/changelog_cleanup

Use unified and clean formatting in CHANGELOGS. [ci skip]
  • Loading branch information...
2 parents 481618c + c245437 commit 1c2f80a66f55e9ba84d7f3848aca47478f212949 @carlosantoniodasilva carlosantoniodasilva committed Apr 12, 2013
Showing with 25 additions and 22 deletions.
  1. +1 −1 actionpack/CHANGELOG.md
  2. +12 −9 activemodel/CHANGELOG.md
  3. +9 −9 activerecord/CHANGELOG.md
  4. +2 −2 activesupport/CHANGELOG.md
  5. +1 −1 railties/CHANGELOG.md
View
2 actionpack/CHANGELOG.md
@@ -64,7 +64,7 @@
*Brad Dunbar*
* Include I18n locale fallbacks in view lookup.
- Fixes GH#3512.
+ Fixes #3512.
*Juan Barreneche*
View
21 activemodel/CHANGELOG.md
@@ -3,6 +3,8 @@
* Add `ActiveModel::Errors#full_messages_for`, to return all the error messages
for a given attribute.
+ Example:
+
class Person
include ActiveModel::Validations
@@ -19,26 +21,27 @@
* Added a method so that validations can be easily cleared on a model.
For example:
- class Person
- include ActiveModel::Validations
+ class Person
+ include ActiveModel::Validations
- validates_uniqueness_of :first_name
- validate :cannot_be_robot
+ validates_uniqueness_of :first_name
+ validate :cannot_be_robot
- def cannot_be_robot
- errors.add(:base, 'A person cannot be a robot') if person_is_robot
+ def cannot_be_robot
+ errors.add(:base, 'A person cannot be a robot') if person_is_robot
+ end
end
- end
Now, if someone runs `Person.clear_validators!`, then the following occurs:
- Person.validators # => []
- Person._validate_callbacks.empty? # => true
+ Person.validators # => []
+ Person._validate_callbacks.empty? # => true
*John Wang*
* `has_secure_password` does not fail the confirmation validation
when assigning empty String to `password` and `password_confirmation`.
+ Fixes #9535.
Example:
View
18 activerecord/CHANGELOG.md
@@ -6,11 +6,11 @@
Example:
- cache = ActiveRecord::StatementCache.new do
- Book.where(name: "my book").limit(100)
- end
+ cache = ActiveRecord::StatementCache.new do
+ Book.where(name: "my book").limit(100)
+ end
- books = cache.execute
+ books = cache.execute
The solution attempts to get closer to the speed of `find_by_sql` but still maintaining
the expressiveness of the Active Record queries.
@@ -44,7 +44,6 @@
Ths solution is to build JoinAssociation when two relations with join information are being
merged. And later while building the arel use the previously built `JoinAssociation` record
in `JoinDependency#graft` to build the right from clause.
-
Fixes #3002.
*Jared Armstrong and Neeraj Singh*
@@ -76,7 +75,8 @@
*Michal Cichra*
* `has_many` using `:through` now obeys the order clause mentioned in
- through association. Fixes #10016.
+ through association.
+ Fixes #10016.
*Neeraj Singh*
@@ -141,7 +141,8 @@
*Ken Mazaika*
* Add an `add_index` override in PostgreSQL adapter and MySQL adapter
- to allow custom index type support. Fixes #6101.
+ to allow custom index type support.
+ Fixes #6101.
add_index(:wikis, :body, :using => 'gin')
@@ -165,7 +166,6 @@
in the association for a particular id. Then, it will go to the DB if it
is not found. This is accomplished by calling `find_by_scan` in
collection associations whenever `options[:inverse_of]` is not nil.
-
Fixes #9470.
*John Wang*
@@ -1275,7 +1275,7 @@
* Explain only normal CRUD sql (select / update / insert / delete).
Fix problem that explains unexplainable sql.
- Closes #7544 #6458.
+ Fixes #7544 #6458.
*kennyj*
View
4 activesupport/CHANGELOG.md
@@ -8,8 +8,8 @@
* `fast_xs` support has been removed. Use `String#encode(xml: :attr)`.
-* `ActiveSupport::Notifications::Instrumenter#instrument` should yield
- its payload.
+* `ActiveSupport::Notifications::Instrumenter#instrument` should
+ yield its payload.
*stopdropandrew*
View
2 railties/CHANGELOG.md
@@ -58,7 +58,7 @@
* Improve service pages with new layout (404, etc).
- *Stanislav Sobolev*
+ *Stanislav Sobolev*
## Rails 4.0.0.beta1 (February 25, 2013) ##

0 comments on commit 1c2f80a

Please sign in to comment.