Skip to content
This repository
Browse code

Fixed that UrlHelper#link_to_unless/link_to_if used html_escape on th…

…e name if no link was to be applied. This is unnecessary and breaks its use with images #1649 [joergd@pobox.com]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
commit 1d7aa9fe813afb1979dfefd0871d84eb60d92d39 1 parent 34cbf15
David Heinemeier Hansson authored July 09, 2005
2  actionpack/CHANGELOG
... ...
@@ -1,5 +1,7 @@
1 1
 *SVN*
2 2
 
  3
+* Fixed that UrlHelper#link_to_unless/link_to_if used html_escape on the name if no link was to be applied. This is unnecessary and breaks its use with images #1649 [joergd@pobox.com]
  4
+
3 5
 * Added even more goodies to script.aculo.us #1677 [Thomas Fuchs]
4 6
   * Added capability to remove draggables/droppables and redeclare sortables in dragdrop.js (this makes it possible to call sortable_element on the same element more than once, e.g. in AJAX returns that modify the sortable element. all current sortable 'stuff' on the element will be discarded and the sortable will be rebuilt)
5 7
   * Always reset background color on Effect.Highlight; this make change backwards-compatibility, to be sure include style="background-color:(target-color)" on your elements or else elements will fall back to their CSS rules (which is a good thing in most circumstances)
2  actionpack/lib/action_view/helpers/url_helper.rb
@@ -143,7 +143,7 @@ def link_to_unless(condition, name, options = {}, html_options = {}, *parameters
143 143
           if block_given?
144 144
             block.arity <= 1 ? yield(name) : yield(name, options, html_options, *parameters_for_method_reference)
145 145
           else
146  
-            html_escape(name)
  146
+            name
147 147
           end
148 148
         else
149 149
           link_to(name, options, html_options, *parameters_for_method_reference)

0 notes on commit 1d7aa9f

Please sign in to comment.
Something went wrong with that request. Please try again.