Skip to content
This repository
Browse code

improve accuracy of simple_format documentation. span doesn't get san…

…itized.
  • Loading branch information...
commit 21b55e4462c2a9d3a6420d2754ab63a9d6f01da8 1 parent c6d9f4e
Russell Norris rsl authored

Showing 1 changed file with 5 additions and 2 deletions. Show diff stats Hide diff stats

  1. +5 2 actionpack/lib/action_view/helpers/text_helper.rb
7 actionpack/lib/action_view/helpers/text_helper.rb
@@ -250,8 +250,11 @@ def word_wrap(text, options = {})
250 250 # simple_format("Look ma! A class!", class: 'description')
251 251 # # => "<p class='description'>Look ma! A class!</p>"
252 252 #
253   - # simple_format("<span>I'm allowed!</span> It's true.", {}, sanitize: false)
254   - # # => "<p><span>I'm allowed!</span> It's true.</p>"
  253 + # simple_format("<blink>Unblinkable.</blink>")
  254 + # # => "<p>Unblinkable.</p>"
  255 + #
  256 + # simple_format("<blink>Blinkable!</blink> It's true.", {}, sanitize: false)
  257 + # # => "<p><blink>Blinkable!</span> It's true.</p>"
255 258 def simple_format(text, html_options = {}, options = {})
256 259 wrapper_tag = options.fetch(:wrapper_tag, :p)
257 260

3 comments on commit 21b55e4

Travis

It should be </blink> not </span>

Robin Dupret
Collaborator

Nice catch ! This is already fixed on master. Thank you!

Damien Mathieu
Collaborator

blink has been removed from firefox 23.0. So we should also use an other thag.

Please sign in to comment.
Something went wrong with that request. Please try again.