Permalink
Browse files

Remove obsolete compatibility module

  • Loading branch information...
pixeltrix committed Jun 13, 2011
1 parent 968816a commit 271bccbcef38397eed8d933c9413c9d6f824467f
Showing with 0 additions and 11 deletions.
  1. +0 −11 activesupport/lib/active_support/dependencies.rb
@@ -608,17 +608,6 @@ def new_constants_in(*descs)
return []
end
- class LoadingModule #:nodoc:
- # Old style environment.rb referenced this method directly. Please note, it doesn't
- # actually *do* anything any more.
- def self.root(*args)
- if defined?(Rails) && Rails.logger
- Rails.logger.warn "Your environment.rb uses the old syntax, it may not continue to work in future releases."
- Rails.logger.warn "For upgrade instructions please see: http://manuals.rubyonrails.com/read/book/19"
- end
- end
- end
-
# Convert the provided const desc to a qualified constant name (as a string).
# A module, class, symbol, or string may be provided.
def to_constant_name(desc) #:nodoc:

7 comments on commit 271bccb

Why is this removed in a 3.0.x point-release? What if someone upgrades from an old release to 3.0? It is not like people are going to upgrade to 3.0.0 to 3.0.1 to 3.0.2, etc. They're going straight to 3.0.10, so they're missing the deprecation warning.

Removing deprecation warnings in a point release doesn't really seem like a good idea. That's what major releases are for.

Owner

tenderlove replied Aug 5, 2011

@vanderhoorn I'm not sure why this was removed. We'll revert it. I'll fold the revert in to 3.0.10, but I won't let this delay the 3.0.10 release.

Contributor

josevalim replied Aug 5, 2011

Owner

tenderlove replied Aug 5, 2011

@josevalim ah, I didn't see how far back it was deprecated. I'll not revert then. Thanks!

Member

vijaydev replied Aug 5, 2011

I remember @pixeltrix removing this when someone edited the url in the warning to change .com to .org.

Owner

pixeltrix replied Aug 6, 2011

This code relates to moving an environment.rb file from 0.x to 1.0. If you're moving a 0.x app to 3.0.x whether a noop method still exists is the least of your problems. Also any environment.rb from that era will be using Dependencies.root which doesn't exist - it's ActiveSupport::Dependencies now.

Ok, that wasn't really clear from the commit message. Thanks for the info.

Please sign in to comment.