Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Anchor DateTimeTest to fixed DateTime instead of a variable value bas…

…ed on Time.now#advance#to_datetime. Works around issue on 64-bit platforms with Ruby's Time#to_datetime respecting fractional seconds, and database adapters not respecting them for DateTimes, throwing off before-and-after-save equality test. References #10080, #10073

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8326 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
commit 2766f7629f318f0f7dadf2286113504113fef562 1 parent 731ecec
Geoff Buesing gbuesing authored
Showing with 7 additions and 3 deletions.
  1. +2 −0  activerecord/CHANGELOG
  2. +5 −3 activerecord/test/date_time_test.rb
2  activerecord/CHANGELOG
View
@@ -1,5 +1,7 @@
*2.0.0* (December 6th, 2007)
+* Anchor DateTimeTest to fixed DateTime instead of a variable value based on Time.now#advance#to_datetime, so that this test passes on 64-bit platforms running Ruby 1.8.6+ [Geoff Buesing]
+
* Fixed that the Query Cache should just be ignored if the database is misconfigured (so that the "About your applications environment" works even before the database has been created) [DHH]
* Fixed that the truncation of strings longer than 50 chars should use inspect so newlines etc are escaped #10385 [norbert]
8 activerecord/test/date_time_test.rb
View
@@ -4,13 +4,15 @@
class DateTimeTest < Test::Unit::TestCase
def test_saves_both_date_and_time
- now = 200.years.ago.to_datetime
+ time_values = [1807, 2, 10, 15, 30, 45]
+ now = DateTime.civil(*time_values)
task = Task.new
task.starting = now
task.save!
-
- assert_equal now, Task.find(task.id).starting.to_datetime
+
+ # check against Time.local_time, since some platforms will return a Time instead of a DateTime
+ assert_equal Time.local_time(*time_values), Task.find(task.id).starting
end
def test_assign_empty_date_time
Please sign in to comment.
Something went wrong with that request. Please try again.