Permalink
Browse files

Added Base.validate_confirmation that encapsulates the pattern of wan…

…ting to validate the acceptance of a terms of service check box (or similar agreement)

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@97 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
dhh committed Dec 9, 2004
1 parent d33f814 commit 27ea0b527e172bbc8f8b68c39c8359ee0c77e435
Showing with 51 additions and 9 deletions.
  1. +16 −0 activerecord/CHANGELOG
  2. +23 −0 activerecord/lib/active_record/validations.rb
  3. +12 −9 activerecord/test/validations_test.rb
View
@@ -17,6 +17,22 @@
NOTE: This validation is only happening on create. When you want to update the record, you'll have to decide and pursue your
own course of action.
+
+* Added Base.validate_confirmation that encapsulates the pattern of wanting to validate the acceptance of a terms of service check box (or similar agreement). Example:
+
+ Model:
+ class Person < ActiveRecord::Base
+ validate_acceptance :terms_of_service
+ end
+
+ View:
+ <%= check_box "person", "terms_of_service" %>
+
+ The terms_of_service attribute is entirely virtual. It's only used for validation at the time of creation. No database column is needed.
+
+ NOTE: The agreement is considered valid if it's set to the string "1". This makes it easy to relate it to an HTML checkbox.
+
+
* Added validation macros to make the stackable just like the lifecycle callbacks. Examples:
class Person < ActiveRecord::Base
@@ -80,6 +80,29 @@ def validate_confirmation(*attr_names)
EOM
end
end
+
+
+ # Encapsulates the pattern of wanting to validate the acceptance of a terms of service check box (or similar agreement). Example:
+ #
+ # Model:
+ # class Person < ActiveRecord::Base
+ # validate_acceptance :terms_of_service
+ # end
+ #
+ # View:
+ # <%= check_box "person", "terms_of_service" %>
+ #
+ # The terms_of_service attribute is entirely virtual. It's only used for validation at the time of creation. No database column is needed.
+ #
+ # NOTE: The agreement is considered valid if it's set to the string "1". This makes it easy to relate it to an HTML checkbox.
+ def validate_acceptance(*attr_names)
+ for attr_name in attr_names
+ attr_accessor(attr_name)
+ class_eval <<-EOM
+ validate_on_create %{errors.add('#{attr_name}', "must be accepted") unless #{attr_name} == "1"}
+EOM
+ end
+ end
end
# The validation process on save can be skipped by passing false. The regular Base#save method is
@@ -120,25 +120,28 @@ def test_errors_on_boundary_breaking
developer.name = "Just right"
assert developer.save
end
-end
+ def test_title_confirmation
+ Topic.validate_confirmation(:title)
-class MacroValidationsTest < Test::Unit::TestCase
- fixtures :topics, :developers
+ t = Topic.create("title" => "We should be confirmed")
+ assert !t.save
- def setup
- Topic.validate_confirmation(:title)
- end
+ t.title_confirmation = "We should be confirmed"
+ assert t.save
- def teardown
Topic.write_inheritable_attribute("validate_on_create", [])
end
- def test_title_confirmation
+ def test_terms_of_service_agreement
+ Topic.validate_acceptance(:terms_of_service)
+
t = Topic.create("title" => "We should be confirmed")
assert !t.save
- t.title_confirmation = "We should be confirmed"
+ t.terms_of_service = "1"
assert t.save
+
+ Topic.write_inheritable_attribute("validate_on_create", [])
end
end

0 comments on commit 27ea0b5

Please sign in to comment.