Permalink
Browse files

Remove tests for not swallowing exceptions.

From PR, @tenderlove would prefer to not maintain these tests.
  • Loading branch information...
dougbarth committed Nov 15, 2013
1 parent 5d870c9 commit 2b0406cedb61c4c2f74ecca61fc07771e911fd35
@@ -164,27 +164,6 @@ def test_mysql_set_session_variable_to_default
end
end
- def test_mysql_begin_db_transaction_can_throw_an_exception
- @connection.expects(:exec_query).with('BEGIN').raises('OH NOES')
- assert_raise RuntimeError do
- @connection.begin_db_transaction
- end
- end
-
- def test_mysql_commit_db_transaction_can_throw_an_exception
- @connection.expects(:execute).with('COMMIT').raises('OH NOES')
- assert_raise RuntimeError do
- @connection.commit_db_transaction
- end
- end
-
- def test_mysql_rollback_db_transaction_can_throw_an_exception
- @connection.expects(:execute).with('ROLLBACK').raises('OH NOES')
- assert_raise RuntimeError do
- @connection.rollback_db_transaction
- end
- end
-
private
def run_without_connection
@@ -89,27 +89,6 @@ def test_logs_name_rename_column_sql
@connection.execute "DROP TABLE `bar_baz`"
end
- def test_mysql_begin_db_transaction_can_throw_an_exception
- @connection.expects(:execute).with('BEGIN').raises('OH NOES')
- assert_raise RuntimeError do
- @connection.begin_db_transaction
- end
- end
-
- def test_mysql_commit_db_transaction_can_throw_an_exception
- @connection.expects(:execute).with('COMMIT').raises('OH NOES')
- assert_raise RuntimeError do
- @connection.commit_db_transaction
- end
- end
-
- def test_mysql_rollback_db_transaction_can_throw_an_exception
- @connection.expects(:execute).with('ROLLBACK').raises('OH NOES')
- assert_raise RuntimeError do
- @connection.rollback_db_transaction
- end
- end
-
private
def run_without_connection

0 comments on commit 2b0406c

Please sign in to comment.