Permalink
Browse files

Merge pull request #5486 from kennyj/fix_5435

Fix GH #5435. db:structure:dump should be re-enable.
  • Loading branch information...
tenderlove committed Mar 18, 2012
2 parents c513ae3 + 0360b3e commit 2b5cb1cd41ea765ae665321236c83c9d0128636b
Showing with 13 additions and 0 deletions.
  1. +1 −0 activerecord/lib/active_record/railties/databases.rake
  2. +12 −0 railties/test/application/rake_test.rb
@@ -426,6 +426,7 @@ db_namespace = namespace :db do
if ActiveRecord::Base.connection.supports_migrations?
File.open(filename, "a") { |f| f << ActiveRecord::Base.connection.dump_schema_information }
end
+ db_namespace['structure:dump'].reenable
end
# desc "Recreate the databases from the structure.sql file"
@@ -140,6 +140,18 @@ def test_rake_dump_structure_should_respect_db_structure_env_variable
assert File.exists?(File.join(app_path, 'db', 'my_structure.sql'))
end
+ def test_rake_dump_structure_should_be_called_twice_when_migrate_redo
+ add_to_config "config.active_record.schema_format = :sql"
+
+ output = Dir.chdir(app_path) do
+ `rails g model post title:string;
+ bundle exec rake db:migrate:redo 2>&1 --trace;`
+ end
+
+ # expect only Invoke db:structure:dump (first_time)
+ assert_no_match(/^\*\* Invoke db:structure:dump\s+$/, output)
+ end
+
def test_rake_dump_schema_cache
Dir.chdir(app_path) do
`rails generate model post title:string;

0 comments on commit 2b5cb1c

Please sign in to comment.