Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Enable partial updates by default

  • Loading branch information...
commit 2ce1be3ac4823ccdfbe36ff5548a562aa5106d2e 1 parent 946f514
@jeremy jeremy authored
Showing with 1 addition and 1 deletion.
  1. +1 −1  activerecord/lib/active_record/dirty.rb
View
2  activerecord/lib/active_record/dirty.rb
@@ -43,7 +43,7 @@ def self.included(base)
base.alias_method_chain :reload, :dirty
base.superclass_delegating_accessor :partial_updates
- base.partial_updates = false
+ base.partial_updates = true
end
# Do any attributes have unsaved changes?

6 comments on commit 2ce1be3

@DefV

This kind of makes this commit (http://github.com/rails/rails/commit/888d5059bdb71e6d034d0c09d7e3b3e235fd8507) useless..

@trevorturk

Yeah, I’m not sure how to read this either. Are partial updates on by default now?

@geoffgarside

Its likely that partial updates are not enabled by default for Rails 2.1, but if you stay on edge then they are enabled by default as per the commit message.

@ncr

I think it needs stronger “opinion”. I like it on by default.

@NZKoz
Owner

It’s on by default, if you have contention-heavy data and you’re not using optimistic locking at present you’re already breaking stuff.

The discussions which resulted in this happened face to face, sorry for the confusion :)

@trevorturk

Thanks for the clarification. I think this is a good default, personally.

Please sign in to comment.
Something went wrong with that request. Please try again.