Permalink
Browse files

Dont stream back cookie value if it was set to the same value

  • Loading branch information...
1 parent ff2667d commit 2d18dd34719b1f9a3d2e3a516ccb83e7067dcd91 @brainopia brainopia committed Apr 30, 2012
Showing with 18 additions and 4 deletions.
  1. +6 −4 actionpack/lib/action_dispatch/middleware/cookies.rb
  2. +12 −0 actionpack/test/dispatch/cookies_test.rb
@@ -169,12 +169,14 @@ def []=(key, options)
options = { :value => value }
end
- @cookies[key.to_s] = value
-
handle_options(options)
- @set_cookies[key.to_s] = options
- @delete_cookies.delete(key.to_s)
+ if @cookies[key.to_s] != value or options[:expires]
+ @cookies[key.to_s] = value
+ @set_cookies[key.to_s] = options
+ @delete_cookies.delete(key.to_s)
+ end
+
value
end
@@ -181,6 +181,18 @@ def test_setting_cookie
assert_equal({"user_name" => "david"}, @response.cookies)
end
+ def test_setting_the_same_value_to_cookie
+ request.cookies[:user_name] = 'david'
+ get :authenticate
+ assert response.cookies.empty?
+ end
+
+ def test_setting_the_same_value_to_permanent_cookie
+ request.cookies[:user_name] = 'Jamie'
+ get :set_permanent_cookie
+ assert response.cookies, 'user_name' => 'Jamie'
+ end
+
def test_setting_with_escapable_characters
get :set_with_with_escapable_characters
assert_cookie_header "that+%26+guy=foo+%26+bar+%3D%3E+baz; path=/"

0 comments on commit 2d18dd3

Please sign in to comment.