Skip to content
Browse files

Remove redundant instance_variables (@colorize_logging)

  • Loading branch information...
1 parent f22a0e2 commit 2e7d6ff08ddcb4f90f1ee78f28e102fb75990f0a @kennyj kennyj committed Jan 27, 2012
View
3 railties/lib/rails/application/configuration.rb
@@ -112,11 +112,10 @@ def log_level
end
def colorize_logging
- @colorize_logging
+ ActiveSupport::LogSubscriber.colorize_logging
end
def colorize_logging=(val)
- @colorize_logging = val
ActiveSupport::LogSubscriber.colorize_logging = val
self.generators.colorize_logging = val
end
View
5 railties/test/application/configuration_test.rb
@@ -534,5 +534,10 @@ def index
assert_equal app.env_config['action_dispatch.logger'], Rails.logger
assert_equal app.env_config['action_dispatch.backtrace_cleaner'], Rails.backtrace_cleaner
end
+
+ test "config.colorize_logging defaul is true" do
@carlosantoniodasilva
Ruby on Rails member

I think it should read "default".

@carlosantoniodasilva
Ruby on Rails member

Sorry, @vijaydev fixed in a8da5d8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ make_basic_app
+ assert app.config.colorize_logging
+ end
end
end

0 comments on commit 2e7d6ff

Please sign in to comment.
Something went wrong with that request. Please try again.