Permalink
Browse files

Correctly report which filter halted the chain. References #6699.

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5715 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
1 parent 55d4dbb commit 2f184c338b6379baecde8c882f72c4fa806a3a0b @jeremy jeremy committed Dec 12, 2006
Showing with 5 additions and 5 deletions.
  1. +2 −0 actionpack/CHANGELOG
  2. +3 −5 actionpack/lib/action_controller/filters.rb
View
@@ -1,5 +1,7 @@
*SVN*
+* Correctly report which filter halted the chain. #6699 [Martin Emde]
+
* Fix a bug in Routing where a parameter taken from the path of the current request could not be used as a query parameter for the next. Closes #6752. [Nicholas Seckar]
* Unrescued ActiveRecord::RecordNotFound responds with 404 instead of 500. [Jeremy Kemper]
@@ -616,10 +616,7 @@ def self.included(base)
end
def perform_action_with_filters
- #result = perform_filters do
- # perform_action_without_filters unless performed?
- #end
- @before_filter_chain_aborted = (call_filter(self.class.filter_chain, 0) == false)
+ call_filter(self.class.filter_chain, 0)
end
def process_with_filters(request, response, method = :perform_action, *arguments) #:nodoc:
@@ -640,7 +637,7 @@ def call_filter(chain, index)
filter.call(self) do
halted = call_filter(chain, index.next)
end
- halt_filter_chain(filter.filter, :no_yield) if halted == false
+ halt_filter_chain(filter.filter, :no_yield) if halted == false unless @before_filter_chain_aborted
halted
end
@@ -653,6 +650,7 @@ def halt_filter_chain(filter, reason)
logger.info "Filter chain halted as [#{filter.inspect}] returned false."
end
end
+ @before_filter_chain_aborted = true
return false
end

0 comments on commit 2f184c3

Please sign in to comment.