Please sign in to comment.
Fix numericality validator not to be affected by custom getter
Since fe9547b, numericality validator would parse raw value only when a value came from user to work type casting to a value from database. But that was caused a regression that the validator would work against getter value instead of parsed raw value, a getter is sometimes customized by people. #33550 There we never guarantees that the value before type cast was going to the used in this validation (actually here is only place that getter value might not be used), but we should not change the behavior unless there is some particular reason. The purpose of fe9547b is to work type casting to a value from database. We could achieve the purpose by using `read_attribute`, without using getter value. Fixes #33550.
- Loading branch information...
Showing with 28 additions and 2 deletions.
|@@ -1,6 +1,14 @@|
|# frozen_string_literal: true|
|class PriceEstimate < ActiveRecord::Base|
|belongs_to :estimate_of, polymorphic: true|
|belongs_to :thing, polymorphic: true|