Permalink
Browse files

use `4-0-stable` arel branch to get bundle working again.

this resolves the following error when running `bundle install`

```
ArgumentError: wrong number of arguments (2 for 1)
    /Users/senny/Projects/rails/.bundle/bundler/gems/arel-454a25f18c95/lib/arel/crud.rb:5:in `compile_update'
```

The build is still broken with lots of:

```
ArgumentError: wrong number of arguments (2 for 1)
    /Users/senny/Projects/rails/.bundle/bundler/gems/arel-454a25f18c95/lib/arel/crud.rb:5:in `compile_update'
```
  • Loading branch information...
senny committed Nov 19, 2013
1 parent 2b18e22 commit 3053fee954c1e28b23f7e00921d7b9b3b3867fa5
Showing with 1 addition and 1 deletion.
  1. +1 −1 Gemfile
View
@@ -12,7 +12,7 @@ gem 'bcrypt-ruby', '~> 3.1.2'
gem 'jquery-rails', '~> 2.2.0'
gem 'turbolinks'
gem 'coffee-rails', '~> 4.0.0'
-gem 'arel', github: 'rails/arel', branch: 'master'
+gem 'arel', github: 'rails/arel', branch: '4-0-stable'
# This needs to be with require false to avoid
# it being automatically loaded by sprockets

6 comments on commit 3053fee

@senny

This comment has been minimized.

Show comment Hide comment
@senny

senny Nov 19, 2013

Member
Member

senny replied Nov 19, 2013

@rafaelfranca

This comment has been minimized.

Show comment Hide comment
@rafaelfranca

rafaelfranca Nov 19, 2013

Owner

Master should use master. If it is broken with arel master we need to fix

Owner

rafaelfranca replied Nov 19, 2013

Master should use master. If it is broken with arel master we need to fix

@senny

This comment has been minimized.

Show comment Hide comment
@senny

senny Nov 19, 2013

Member

@rafaelfranca should I update the activerecord gem to depend on arel 5.0.0?

Member

senny replied Nov 19, 2013

@rafaelfranca should I update the activerecord gem to depend on arel 5.0.0?

@ffmike

This comment has been minimized.

Show comment Hide comment
@ffmike

ffmike Nov 19, 2013

Contributor

There's a change to the way Rails calls arel at
8d7d2df
which corresponds to the arel change at
rails/arel@aa14068

The mismatch between the two is what's causing the "2 for 1" issues.

It looks to me like the right fix here is to update activerecord to depend on arel 5.0.0 now that arel has taken a version bump at rails/arel@cd0509d

Contributor

ffmike replied Nov 19, 2013

There's a change to the way Rails calls arel at
8d7d2df
which corresponds to the arel change at
rails/arel@aa14068

The mismatch between the two is what's causing the "2 for 1" issues.

It looks to me like the right fix here is to update activerecord to depend on arel 5.0.0 now that arel has taken a version bump at rails/arel@cd0509d

@senny

This comment has been minimized.

Show comment Hide comment
@senny

senny Nov 19, 2013

Member

Updated with a6f58a5

Member

senny replied Nov 19, 2013

Updated with a6f58a5

@rafaelfranca

This comment has been minimized.

Show comment Hide comment
@rafaelfranca

rafaelfranca Nov 19, 2013

Owner

👍

Owner

rafaelfranca replied Nov 19, 2013

👍

Please sign in to comment.