Skip to content
This repository
Browse code

Fix HasManyThrough Association so it uses :conditions on the HasMany …

…Association. Closes #9729 [danger]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8128 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
commit 3104291322b4f1834d342eef740c23427f36384d 1 parent 49cb412
risk danger olson authored
2  activerecord/CHANGELOG
... ...
@@ -1,5 +1,7 @@
1 1
 *SVN*
2 2
 
  3
+* Fix HasManyThrough Association so it uses :conditions on the HasMany Association.  Closes #9729 [danger]
  4
+
3 5
 * Ensure that column names are quoted.  Closes #10134 [wesley.moxam]
4 6
 
5 7
 * Smattering of grammatical fixes to documentation. Closes #10083 [BobSilva]
3  activerecord/lib/active_record/associations/has_many_through_association.rb
@@ -262,8 +262,9 @@ def conditions
262 262
           @conditions ||= [
263 263
             (interpolate_sql(@reflection.klass.send(:sanitize_sql, @reflection.options[:conditions])) if @reflection.options[:conditions]),
264 264
             (interpolate_sql(@reflection.active_record.send(:sanitize_sql, @reflection.through_reflection.options[:conditions])) if @reflection.through_reflection.options[:conditions]),
  265
+            (interpolate_sql(@reflection.active_record.send(:sanitize_sql, @reflection.source_reflection.options[:conditions])) if @reflection.source_reflection.options[:conditions]),
265 266
             ("#{@reflection.through_reflection.table_name}.#{@reflection.through_reflection.klass.inheritance_column} = #{@reflection.klass.quote_value(@reflection.through_reflection.klass.name.demodulize)}" unless @reflection.through_reflection.klass.descends_from_active_record?)
266  
-          ].compact.collect { |condition| "(#{condition})" }.join(' AND ') unless (!@reflection.options[:conditions] && !@reflection.through_reflection.options[:conditions] && @reflection.through_reflection.klass.descends_from_active_record?)
  267
+          ].compact.collect { |condition| "(#{condition})" }.join(' AND ') unless (!@reflection.options[:conditions] && !@reflection.through_reflection.options[:conditions]  && !@reflection.source_reflection.options[:conditions] && @reflection.through_reflection.klass.descends_from_active_record?)
267 268
         end
268 269
 
269 270
         alias_method :sql_conditions, :conditions
6  activerecord/test/associations/join_model_test.rb
@@ -410,6 +410,12 @@ def test_add_to_self_referential_has_many_through
410 410
     authors(:david).author_favorites.create :favorite_author => new_author
411 411
     assert_equal new_author, authors(:david).reload.favorite_authors.first
412 412
   end
  413
+  
  414
+  def test_has_many_through_uses_conditions_specified_on_the_has_many_association
  415
+    author = Author.find(:first)
  416
+    assert !author.comments.blank?
  417
+    assert author.nonexistant_comments.blank?
  418
+  end
413 419
 
414 420
   def test_has_many_through_uses_correct_attributes
415 421
     assert_nil posts(:thinking).tags.find_by_name("General").attributes["tag_id"]
1  activerecord/test/fixtures/author.rb
@@ -22,6 +22,7 @@ def testing_proxy_target
22 22
   
23 23
   has_many :special_nonexistant_posts, :class_name => "SpecialPost", :conditions => "posts.body = 'nonexistant'"
24 24
   has_many :special_nonexistant_post_comments, :through => :special_nonexistant_posts, :source => :comments, :conditions => "comments.post_id = 0"
  25
+  has_many :nonexistant_comments, :through => :posts
25 26
 
26 27
   has_many :hello_posts, :class_name => "Post", :conditions => "posts.body = 'hello'"
27 28
   has_many :hello_post_comments, :through => :hello_posts, :source => :comments
1  activerecord/test/fixtures/post.rb
@@ -16,6 +16,7 @@ def find_most_recent
16 16
   has_one  :very_special_comment
17 17
   has_one  :very_special_comment_with_post, :class_name => "VerySpecialComment", :include => :post
18 18
   has_many :special_comments
  19
+  has_many :nonexistant_comments, :class_name => 'Comment', :conditions => 'comments.id < 0'
19 20
 
20 21
   has_and_belongs_to_many :categories
21 22
   has_and_belongs_to_many :special_categories, :join_table => "categories_posts", :association_foreign_key => 'category_id'

0 notes on commit 3104291

Please sign in to comment.
Something went wrong with that request. Please try again.