Skip to content

Commit

Permalink
Merge pull request #11451 from jetthoughts/11450_do_not_resave_destro…
Browse files Browse the repository at this point in the history
…yed_association

Do not re-save destroyed association on saving parent object
  • Loading branch information
senny committed Jul 15, 2013
1 parent d635246 commit 317527d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions activerecord/lib/active_record/autosave_association.rb
Expand Up @@ -343,6 +343,7 @@ def save_collection_association(reflection)
end

records.each do |record|
next if record.destroyed?

saved = true

Expand Down
7 changes: 7 additions & 0 deletions activerecord/test/cases/autosave_association_test.rb
Expand Up @@ -705,6 +705,13 @@ def test_should_destroy_has_many_as_part_of_the_save_transaction_if_they_were_ma
ids.each { |id| assert_nil klass.find_by_id(id) }
end

def test_should_not_resave_destroyed_association
@pirate.birds.create!(name: :parrot)
@pirate.birds.first.destroy
@pirate.save!
assert @pirate.reload.birds.empty?
end

def test_should_skip_validation_on_has_many_if_marked_for_destruction
2.times { |i| @pirate.birds.create!(:name => "birds_#{i}") }

Expand Down

0 comments on commit 317527d

Please sign in to comment.