Permalink
Browse files

Tidy up a bit this code

  • Loading branch information...
1 parent 1a0f72d commit 31ac1db59600e00eeb098e29b43c073f239e2a1d @spastorino spastorino committed Oct 18, 2010
Showing with 6 additions and 4 deletions.
  1. +6 −4 actionpack/lib/action_view/helpers/number_helper.rb
@@ -63,14 +63,16 @@ def number_to_phone(number, options = {})
extension = options[:extension]
country_code = options[:country_code]
- str = ""
- str << "+#{country_code}#{delimiter}" unless country_code.blank?
- str << if area_code
+ if area_code
number.gsub!(/([0-9]{1,3})([0-9]{3})([0-9]{4}$)/,"(\\1) \\2#{delimiter}\\3")
else
number.gsub!(/([0-9]{0,3})([0-9]{3})([0-9]{4})$/,"\\1#{delimiter}\\2#{delimiter}\\3")
- number.starts_with?('-') ? number.slice!(1..-1) : number
+ number.slice!(0, 1) if number.starts_with?('-')
end
+
+ str = ""
+ str << "+#{country_code}#{delimiter}" unless country_code.blank?
+ str << number
str << " x #{extension}" unless extension.blank?
html_escape(str)
end

0 comments on commit 31ac1db

Please sign in to comment.