Permalink
Browse files

adds a missing require

  • Loading branch information...
fxn committed Oct 9, 2012
1 parent 0e6c70e commit 3395633a5045fce1f9a9d25f86ba897491874d15
Showing with 1 addition and 0 deletions.
  1. +1 −0 activesupport/test/core_ext/hash_ext_test.rb
@@ -6,6 +6,7 @@
require 'active_support/core_ext/object/deep_dup'
require 'active_support/inflections'
require 'active_support/core_ext/object/to_param'
+require 'active_support/core_ext/object/to_query'

This comment has been minimized.

Show comment Hide comment
@frodsan

frodsan Oct 9, 2012

Contributor

Do we need this require 'active_support/core_ext/object/to_param'? I think this line is inside of 'active_support/core_ext/object/to_query': https://github.com/rails/rails/blob/master/activesupport/lib/active_support/core_ext/object/to_query.rb#L1

@frodsan

frodsan Oct 9, 2012

Contributor

Do we need this require 'active_support/core_ext/object/to_param'? I think this line is inside of 'active_support/core_ext/object/to_query': https://github.com/rails/rails/blob/master/activesupport/lib/active_support/core_ext/object/to_query.rb#L1

This comment has been minimized.

Show comment Hide comment
@fxn

fxn Oct 9, 2012

Owner

Yeah, this file uses to_hash and to_query and it should not rely on the fact that one of them depends on the other.

@fxn

fxn Oct 9, 2012

Owner

Yeah, this file uses to_hash and to_query and it should not rely on the fact that one of them depends on the other.

class HashExtTest < ActiveSupport::TestCase
class IndifferentHash < HashWithIndifferentAccess

0 comments on commit 3395633

Please sign in to comment.