Permalink
Browse files

removing nonsensical tests, limit now actually adds a limit

  • Loading branch information...
1 parent 55736ef commit 3480551e67d2bd97b50a9f95b8f0a49132c38bec @tenderlove tenderlove committed Sep 15, 2010
View
@@ -1,7 +1,19 @@
*Rails 3.1.0 (unreleased)*
-* No changes
+* The following code:
+ Model.limit(10).scoping { Model.count }
+
+ now generates the following SQL:
+
+ SELECT COUNT(*) FROM models LIMIT 10
+
+ This may not return what you want. Instead, you may with to do something
rohit
rohit Sep 16, 2010 Contributor

You meant "...may want to do..." ? :)

+ like this:
+
+ Model.limit(10).scoping { Model.all.size }
+
+ [Aaron Patterson]
*Rails 3.0.0 (August 29, 2010)*
@@ -161,7 +161,7 @@ def test_merge_options
def test_merge_inner_scope_has_priority
Developer.limit(5).scoping do
Developer.limit(10).scoping do
- assert_equal 10, Developer.count
+ assert_equal 10, Developer.all.size
end
end
end
@@ -679,10 +679,6 @@ def test_order_by_relation_attribute
assert_equal Post.order(Post.arel_table[:title]).all, Post.order("title").all
end
- def test_relations_limit_with_conditions_or_limit
- assert_equal Post.limit(2).size, Post.limit(2).all.size
- end
-
def test_order_with_find_with_order
assert_equal 'zyke', Car.order('name desc').find(:first, :order => 'id').name
end

0 comments on commit 3480551

Please sign in to comment.