Permalink
Browse files

Added that page caching will only happen if the response code is less…

… than 400 (closes #4033) [g.bucher@teti.ch]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3738 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
1 parent f62b8af commit 3574ab30596ad3313607927505aed115b740fc87 @dhh dhh committed Mar 2, 2006
Showing with 3 additions and 1 deletion.
  1. +2 −0 actionpack/CHANGELOG
  2. +1 −1 actionpack/lib/action_controller/caching.rb
View
@@ -1,5 +1,7 @@
*SVN*
+* Added that page caching will only happen if the response code is less than 400 #4033 [g.bucher@teti.ch]
+
* Add ActionController::IntegrationTest to allow high-level testing of the way the controllers and routes all work together [Jamis Buck]
* Added support to AssetTagHelper#javascript_include_tag for having :defaults appear anywhere in the list, so you can now make one call ala javascript_include_tag(:defaults, "my_scripts") or javascript_include_tag("my_scripts", :defaults) depending on how you want the load order #3506 [Bob Silva]
@@ -134,7 +134,7 @@ def cache_page(content = nil, options = {})
private
def caching_allowed
- !@request.post?
+ !@request.post? && @response.headers['Status'] && @response.headers['Status'].to_i < 400
end
end

0 comments on commit 3574ab3

Please sign in to comment.