Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Accept :remote as symbol in link_to options

Accept either :remote or 'remote' in both the html_options and
(url_)options hash arguments to link_to.
  • Loading branch information...
commit 380800e4a272db98f3dd267f82e0ce1e4d03f4b8 1 parent 92d7612
Riley Martinez-Lynch teleological authored teleological committed
2  actionpack/CHANGELOG.md
View
@@ -1,5 +1,7 @@
## Rails 3.2.9 (unreleased) ##
+* Accept :remote as symbolic option for `link_to` helper. *Riley Lynch*
+
* Warn when the `:locals` option is passed to `assert_template` outside of a view test case
Fix #3415
4 actionpack/lib/action_view/helpers/url_helper.rb
View
@@ -633,7 +633,9 @@ def convert_options_to_data_attributes(options, html_options)
end
def link_to_remote_options?(options)
- options.is_a?(Hash) && options.key?('remote') && options.delete('remote')
+ if options.is_a?(Hash)
+ options.delete('remote') || options.delete(:remote)
+ end
end
def add_method_to_attributes!(html_options, method)
7 actionpack/test/template/url_helper_test.rb
View
@@ -227,6 +227,13 @@ def test_link_to_with_remote_false
)
end
+ def test_link_to_with_symbolic_remote_in_non_html_options
+ assert_dom_equal(
+ "<a href=\"/\" data-remote=\"true\">Hello</a>",
+ link_to("Hello", hash_for([:remote, true]), {})
+ )
+ end
+
def test_link_tag_using_post_javascript
assert_dom_equal(
"<a href='http://www.example.com' data-method=\"post\" rel=\"nofollow\">Hello</a>",
Please sign in to comment.
Something went wrong with that request. Please try again.