Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Use the reference for the mime type to get the format
Before we were calling to_sym in the mime type, even when it is unknown what can cause denial of service since symbols are not removed by the garbage collector. Fixes: CVE-2014-0082
- Loading branch information
1 parent
eaa2101
commit 388d2f8
Showing
2 changed files
with
18 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| require 'abstract_unit' | ||
|
|
||
| class TextTest < ActiveSupport::TestCase | ||
| test 'formats returns symbol for recognized MIME type' do | ||
| assert_equal [:text], ActionView::Template::Text.new('', :text).formats | ||
| end | ||
|
|
||
| test 'formats returns string for recognized MIME type when MIME does not have symbol' do | ||
| foo = Mime::Type.lookup("foo") | ||
| assert_nil foo.to_sym | ||
| assert_equal ['foo'], ActionView::Template::Text.new('', foo).formats | ||
| end | ||
|
|
||
| test 'formats returns string for unknown MIME type' do | ||
| assert_equal ['foo'], ActionView::Template::Text.new('', 'foo').formats | ||
| end | ||
| end |