Permalink
Browse files

Fix missing dependency on Hash#to_query

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
  • Loading branch information...
1 parent ef6cdc9 commit 399d5338acdebd51648c8ed784e38e7a7c2d8867 @spastorino spastorino committed with jeremy Apr 15, 2010
Showing with 1 addition and 0 deletions.
  1. +1 −0 actionpack/lib/action_controller/test_case.rb
@@ -1,5 +1,6 @@
require 'rack/session/abstract/id'
require 'active_support/core_ext/object/blank'
+require 'active_support/core_ext/object/to_query'
module ActionController
module TemplateAssertions

9 comments on commit 399d533

Owner

spastorino replied Apr 15, 2010

ohh really sorry matthewrudy but it wasn't on purpose. I've been working on Yehuda's ActionController big changes since a few days ago.
We have lot of troubles now on AC so try another patch assign it to me and i'm going to ensure you the preference ;).

Contributor

matthewrudy replied Apr 15, 2010

ha
don't worry.

I've been trying to commit stuff to actionpack
but its impossible to get the tests to pass

here's another similar issue
https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/4398-patch-actiondispatchdeprecatedmapper-needs-with_options

Contributor

matthewrudy replied Apr 15, 2010

but I still get about 40 failures to do with missing routes
eg.

test_mounting_works_with_scope(TestRoutingMount):
ActionController::RoutingError: No route matches "/its_a/sprocket/omg"
/Users/matthew/code/rude-rails/actionpack/lib/action_dispatch/routing/route_set.rb:9
Contributor

matthewrudy replied Apr 15, 2010

also
some xml builder output seems to double output
eg.

<"<body>\n  <p>Builder</p>\n</body>\n"> expected but was
<"<body>\n  <p>Builder</p>\n<body>\n  <p>Builder</p>\n</body>\n">.
Contributor

matthewrudy replied Apr 15, 2010

but anyway
I should be working

spent most of yesterday
trying to sort out my copy of actionpack
largely hampered by this rack-mount issue
(I tried to use 0.6.1 to fix it... but it seems going back to 0.6.0 was the best option)

Owner

spastorino replied Apr 15, 2010

yes i was digging on that and suggested a partial revert on 0.6.2 commit and then Jeremy prefer going back to 0.6.0 which i think is the best option too.

Owner

spastorino replied Apr 15, 2010

I'm have half of the work done on the fixes on actionpack but if you find something let me know, thanks.

Contributor

matthewrudy replied Apr 15, 2010

cool...
I doubt I'll find time today.

Good luck fixing everything
:)

Please sign in to comment.