Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Remove deprecated
sanitize_sql_hash_for_conditions
- Loading branch information
1 parent
ede8c19
commit 3a59dd2
Showing
3 changed files
with
4 additions
and
40 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3a59dd2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removed the code,
but
sanitize_sql_hash_for_conditions
is still called insidesanitize_conditions
as of master.3a59dd2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think this was a really useful method.
And it seems everyone is now having to hack around it to achieve the same result.
https://github.com/CanCanCommunity/cancancan/blob/7393b94ca1788879b7ba968c9fb3c6df3806f678/lib/cancan/model_adapters/active_record_4_adapter.rb#L22-L35
3a59dd2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I issued a PR to remove the remaining call to the method.
#20121