Remove BestStandardsSupport middleware

rails · Jan 29, 2013 · 3bccd12 · 3bccd12 · rubys · Jun 13, 2013
1 parent 88e4ec6
commit 3bccd12
Show file tree

Hide file tree

Showing 9 changed files with 3 additions and 108 deletions.
diff --git a/actionpack/lib/action_dispatch.rb b/actionpack/lib/action_dispatch.rb
@@ -47,7 +47,6 @@ class IllegalStateError < StandardError
 
   autoload_under 'middleware' do
     autoload :RequestId
-    autoload :BestStandardsSupport
     autoload :Callbacks
     autoload :Cookies
     autoload :DebugExceptions

diff --git a/actionpack/lib/action_dispatch/middleware/best_standards_support.rb b/actionpack/lib/action_dispatch/middleware/best_standards_support.rb
diff --git a/actionpack/lib/action_dispatch/railtie.rb b/actionpack/lib/action_dispatch/railtie.rb
@@ -6,7 +6,6 @@ class Railtie < Rails::Railtie # :nodoc:
     config.action_dispatch.x_sendfile_header = nil
     config.action_dispatch.ip_spoofing_check = true
     config.action_dispatch.show_exceptions = true
-    config.action_dispatch.best_standards_support = true
     config.action_dispatch.tld_length = 1
     config.action_dispatch.ignore_accept_header = false
     config.action_dispatch.rescue_templates = { }

diff --git a/actionpack/test/dispatch/best_standards_support_test.rb b/actionpack/test/dispatch/best_standards_support_test.rb
diff --git a/railties/lib/rails/application.rb b/railties/lib/rails/application.rb
@@ -365,10 +365,6 @@ def default_middleware_stack #:nodoc:
         middleware.use ::Rack::Head
         middleware.use ::Rack::ConditionalGet
         middleware.use ::Rack::ETag, "no-cache"
-
-        if config.action_dispatch.best_standards_support
-          middleware.use ::ActionDispatch::BestStandardsSupport, config.action_dispatch.best_standards_support
-        end
       end
     end
 

diff --git a/railties/lib/rails/configuration.rb b/railties/lib/rails/configuration.rb
@@ -27,11 +27,11 @@ module Configuration
     #
     # Middlewares can also be completely swapped out and replaced with others:
     #
-    #     config.middleware.swap ActionDispatch::BestStandardsSupport, Magical::Unicorns
+    #     config.middleware.swap ActionDispatch::Flash, Magical::Unicorns
     #
     # And finally they can also be removed from the stack completely:
     #
-    #     config.middleware.delete ActionDispatch::BestStandardsSupport
+    #     config.middleware.delete ActionDispatch::Flash
     #
     class MiddlewareStackProxy
       def initialize

diff --git a/railties/lib/rails/generators/rails/app/templates/config/environments/development.rb.tt b/railties/lib/rails/generators/rails/app/templates/config/environments/development.rb.tt
@@ -19,9 +19,6 @@
   # Print deprecation notices to the Rails logger.
   config.active_support.deprecation = :log
 
-  # Only use best-standards-support built into browsers.
-  config.action_dispatch.best_standards_support = :builtin
-
   <%- unless options.skip_active_record? -%>
   # Log the query plan for queries taking more than this (works
   # with SQLite, MySQL, and PostgreSQL).

diff --git a/railties/test/application/middleware/best_practices_test.rb b/railties/test/application/middleware/best_practices_test.rb
diff --git a/railties/test/application/middleware_test.rb b/railties/test/application/middleware_test.rb
@@ -45,8 +45,7 @@ def app
         "ActionDispatch::ParamsParser",
         "Rack::Head",
         "Rack::ConditionalGet",
-        "Rack::ETag",
-        "ActionDispatch::BestStandardsSupport"
+        "Rack::ETag"
       ], middleware
     end