Remove depreacted finders

They were deprecated in 4.0, planned to remove in 4.1

Author: lukaszx0

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Remove `activerecord-deprecated_finders` as a dependency
+
+    *Łukasz Strzałkowski*
+
 *   Remove Oracle / Sqlserver / Firebird database tasks that were deprecated in 4.0.
 
     *kennyj*

activerecord/activerecord.gemspec

@@ -25,5 +25,4 @@ Gem::Specification.new do |s|
   s.add_dependency 'activemodel',   version
 
   s.add_dependency 'arel',                            '~> 4.0.0'
-  s.add_dependency 'activerecord-deprecated_finders', '~> 1.0.2'
 end

activerecord/lib/active_record.rb

@@ -25,7 +25,6 @@
 require 'active_support/rails'
 require 'active_model'
 require 'arel'
-require 'active_record/deprecated_finders'
 
 require 'active_record/version'
 

activerecord/test/cases/associations/eager_test.rb

@@ -554,9 +554,9 @@ def test_eager_with_has_many_and_limit_and_conditions_array_on_the_eagers
     assert_equal 2, posts.size
 
     count = ActiveSupport::Deprecation.silence do
-      Post.count(:include => [ :author, :comments ], :limit => 2, :conditions => [ "authors.name = ?", 'David' ])
+      Post.includes(:author, :comments).limit(2).references(:author).where("authors.name = ?", 'David').count
     end
-    assert_equal count, posts.size
+    assert_equal posts.size, count
   end
 
   def test_eager_with_has_many_and_limit_and_high_offset