Skip to content

Commit

Permalink
Improve the test code for #8422
Browse files Browse the repository at this point in the history
* Remove unneeded comments.
* Use key? instead of keys.include?.
  • Loading branch information
rafaelfranca committed Oct 24, 2013
1 parent 669b088 commit 3dcb238
Showing 1 changed file with 4 additions and 4 deletions.
Expand Up @@ -5,13 +5,13 @@
class DescendantsTrackerWithoutAutoloadingTest < ActiveSupport::TestCase
include DescendantsTrackerTestCases

# Regression test for #8422. https://github.com/rails/rails/issues/8442
def test_clear_without_autoloaded_singleton_parent
mark_as_autoloaded do
parent_instance = Parent.new
parent_instance.singleton_class.descendants #adds singleton class in @@direct_descendants
ActiveSupport::DescendantsTracker.clear #clear is supposed to remove singleton class keys so GC can remove them.
assert !ActiveSupport::DescendantsTracker.class_variable_get(:@@direct_descendants).keys.include?(parent_instance.singleton_class)
parent_instance.singleton_class.descendants
ActiveSupport::DescendantsTracker.clear
assert !ActiveSupport::DescendantsTracker.class_variable_get(:@@direct_descendants).key?(parent_instance.singleton_class)
end
end

end

0 comments on commit 3dcb238

Please sign in to comment.