Call yarn directly (#43641)

* Remove the assets:precompile dependency on yarn:install

Since yarn isn't required for Rails 7, assets:precompile should
not depend on it by default. Instead, tasks for webpacker,
jsbundling-rails, cssbundling-rails, etc should depend on
yarn:install on their own.

* In yarn:install, call `yarn` instead of `bin/yarn`

Change to calling `yarn` directly (via PATH) as `bin/yarn` is no longer
a part of Rails 7.

Author: zarqman

railties/lib/rails/tasks/yarn.rake

@@ -10,25 +10,20 @@ namespace :yarn do
     end
 
     yarn_flags =
-      if `#{RbConfig.ruby} "#{Rails.root}/bin/yarn" --version`.start_with?("1")
+      if `yarn --version`.start_with?("1")
         "--no-progress --frozen-lockfile"
       else
         "--immutable"
       end
 
     system(
       { "NODE_ENV" => node_env },
-      "#{RbConfig.ruby} \"#{Rails.root}/bin/yarn\" install #{yarn_flags}",
+      "yarn install #{yarn_flags}",
       exception: true
     )
   rescue Errno::ENOENT
-    $stderr.puts "bin/yarn was not found."
-    $stderr.puts "Please run `bundle exec rails app:update:bin` to create it."
+    $stderr.puts "yarn install failed to execute."
+    $stderr.puts "Ensure yarn is installed and `yarn --version` runs without errors."
     exit 1
   end
 end
-
-# Run Yarn prior to Sprockets assets precompilation, so dependencies are available for use.
-if Rake::Task.task_defined?("assets:precompile") && File.exist?(Rails.root.join("bin", "yarn"))
-  Rake::Task["assets:precompile"].enhance [ "yarn:install" ]
-end