Skip to content
Browse files

Fix ActiveRecord::Relation#blank? tests

  • Loading branch information...
1 parent 090156a commit 404d785d29680d03d8a7f99de9d5986706c4c2a1 @rafaelfranca rafaelfranca committed
Showing with 15 additions and 12 deletions.
  1. +15 −12 activerecord/test/cases/relations_test.rb
View
27 activerecord/test/cases/relations_test.rb
@@ -1238,18 +1238,21 @@ def test_automatically_added_order_references
def test_presence
topics = Topic.scoped
- assert_queries(1) do
- #checking if there are topics is used before you actually display them,
- #thus it shouldn't invoke an extra count query
- assert topics.present?
- assert !topics.blank?
-
- #shows count of topics and loops after loading the query should not trigger extra queries either
- assert_no_queries { topics.size }
- assert_no_queries { topics.count }
- assert_no_queries { topics.length }
- assert_no_queries { topics.each }
- end
+ # the fist query is triggered because there are no topics yet.
+ assert_queries(1) { assert topics.present? }
+
+ # checking if there are topics is used before you actually display them,
+ # thus it shouldn't invoke an extra count query.
+ assert_no_queries { assert topics.present? }
+ assert_no_queries { assert !topics.blank? }
+
+ # shows count of topics and loops after loading the query should not trigger extra queries either.
+ assert_no_queries { topics.size }
+ assert_no_queries { topics.length }
+ assert_no_queries { topics.each }
+
+ # count always trigger the COUNT query.
+ assert_queries(1) { topics.count }
assert topics.loaded?
end

0 comments on commit 404d785

Please sign in to comment.
Something went wrong with that request. Please try again.