Browse files

The deprecated ActiveSupport::Base64.decode64 method should call ::Ba…

…se64.decode64 not ::Base64.encode64
  • Loading branch information...
1 parent ede01ce commit 44319eff4aa6494e1eb383aa767948b20592da04 @jviney jviney committed Jan 23, 2012
Showing with 1 addition and 1 deletion.
  1. +1 −1 activesupport/lib/active_support/base64.rb
@@ -40,7 +40,7 @@ def self.encode64(value)
def self.decode64(value)
ActiveSupport::Deprecation.warn "ActiveSupport::Base64.decode64 " \
"is deprecated. Use Base64.decode64 instead", caller
- ::Base64.encode64(value)
+ ::Base64.decode64(value)
def self.encode64s(value)

3 comments on commit 44319ef

lzap commented on 44319ef Jan 25, 2012

Is this a typo? What is wrong here? Should be ENCODE not DECODE.

drogus commented on 44319ef Jan 25, 2012

@lzap look at the method name, this is self.decode64 method, therefore it should call decode

lzap commented on 44319ef Jan 25, 2012

Ah it was wrong and now it is correct. Was coming from ApiDoc where it was still incorrect :-) Great. TY.

Please sign in to comment.