Permalink
Browse files

Fixed JavascriptHelper#auto_complete_for to only include unique items #…

…2153 [Thomas Fuchs]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2159 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
1 parent 079d8f4 commit 46110aa689412816d077b1f248a6cdb4d9552eda @dhh dhh committed Sep 9, 2005
View
@@ -1,5 +1,7 @@
*SVN*
+* Fixed JavascriptHelper#auto_complete_for to only include unique items #2153 [Thomas Fuchs]
+
* Fixed all AssetHelper methods to work with relative paths, such that javascript_include_tag('stdlib/standard') will look in /javascripts/stdlib/standard instead of '/stdlib/standard/' #1963
* Avoid extending view instance with helper modules each request. Closes #1979
@@ -396,7 +396,7 @@ def auto_complete_field(field_id, options = {})
def auto_complete_result(entries, field, phrase = nil)
return unless entries
items = entries.map { |entry| content_tag("li", phrase ? highlight(entry[field], phrase) : h(entry[field])) }
- content_tag("ul", items)
+ content_tag("ul", items.uniq)
end
# Wrapper for text_field with added AJAX autocompletion functionality.
@@ -127,6 +127,10 @@ def test_auto_complete_result
auto_complete_result(result, :title)
assert_equal %(<ul><li>t<strong class=\"highlight\">est</strong>1</li><li>t<strong class=\"highlight\">est</strong>2</li></ul>),
auto_complete_result(result, :title, "est")
+
+ resultuniq = [ { :title => 'test1' }, { :title => 'test1' } ]
+ assert_equal %(<ul><li>t<strong class=\"highlight\">est</strong>1</li></ul>),
+ auto_complete_result(resultuniq, :title, "est")
end
def test_text_field_with_auto_complete

0 comments on commit 46110aa

Please sign in to comment.